Add clickable metadata support to embedded Victory bar charts - #96065

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

If this requires C+ review, I'll be reviewing this as part of project.

Yeah agree, I would think the y axis would use smaller amounts so the bars would be taller? That feels odd for sure.

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

🤖 Review — clickable metadata on embedded Victory bar charts

Solid, well-structured PR with good test coverage (parser metadata, geometry math, coordinate normalization). I dug into the two riskiest areas — the web coordinate-scaling and the new worklet hit-testing — and both check out. No blocking bugs found. A few non-blocking questions below.

Verified correct:

• Coordinate scaling (coordinateScale divide): correct direction on web. The transform scale is applied to the inner content view while the chart is laid out at design size, so RNGH reports gesture coords in rendered space (getBoundingClientRect-based) while pointOX/chartBounds stay in design space. e.x / scaledScale maps rendered → design, matching the point positions. The tooltip has no space mismatch either — onLayout width is offsetWidth (layout/design space), consistent with initialTooltipPosition.
• Hit-test geometry in getVictoryBarInteractionGeometry.ts matches victory-native's useBarWidth/useBarGroupPaths formulas (ungrouped + grouped, incl. BAR_INNER_PADDING and offset), and divide-by-zero is guarded (pointCount<=0 → 0, Math.max(1, …)).
• Index-space alignment: xs/ys/widths/searchQueryFlags are all built in one pass over interactiveBars, so matchedIndex ↔ interactiveBars[i] ↔ pointWidth[i] stay consistent — no off-by-one.
• Negative-index safety: every .at() on a possibly--1 index is guarded (JS .at(-1) returning the last element is a classic trap, and it's avoided here).
• Metadata key parity: getChartPointMetadataKey embeds typeof, and write (point.x) vs read (row[X_KEY]) use the same value on the vertical path (horizontal is excluded from interactivity), so lookups never miss.
• Percentage denominator: interactiveBars ⊆ visibleVerticalBarValues, so the active bar's value is always part of the total — % of total is well-defined.

Non-blocking questions / notes:

1. Expand/fullscreen modal isn't interactive. BaseVictoryChartRenderer now renders VictoryChartInteractiveContent, but VictoryChartExpandModal still renders the non-interactive VictoryChartContent (L129, L145). So hover tooltips / tap-to-search won't work in the expanded view. Is that intended (inline-only), or should the modal get the same treatment?

2. Bars with only searchQuery (no label/currency) still show a tooltip of just the raw x value, since label defaults to String(xValue) (useVictoryBarInteractions.ts:106) with an empty amount. Is a bare-x-value tooltip desired here, or should those bars be click-only?

3. Minor / cosmetic: hasTooltipLabels (useVictoryBarInteractions.ts:268) is effectively always true because label is defaulted above — the guard is dead. Not worth a change unless you're touching this area.

4. Reactive → imperative flag refactor: switching isTooltipActive/isCursorOverClickable/isCursorOverTarget from useDerivedValue to plain useSharedValue updated only inside gesture callbacks is fine for all current consumers (they read via useAnimatedStyle/useAnimatedReaction, which re-run on any write). The only behavioral delta: chartBottom.set(...) runs during relayout outside a gesture and no longer refreshes the flags until the next pointer event. Only observable if a relayout happens while the pointer sits perfectly still over a bar — acceptable, just flagging it.

_{Findings above were verified against victory-native and react-native-gesture-handler/-web internals; confidence is high, but I didn't run the app — the manual/QA steps still stand.}

🤖 Regression scan

I compared old vs. new behavior across every chart type that flows through the shared render/parse/interaction paths this PR touched (line, area, scatter, vertical bar, horizontal bar, pie, donut — both the embedded Concierge charts and the standalone analytics charts). No hard regressions found. Two behavioral changes are worth a conscious sign-off:

1. Existing vertical bar charts with a labels attribute now become interactive (verify this is intended).
The parser fills point metadata from the labels attribute as a fallback (victorySeriesParser.ts:27-31), so any pre-existing vertical bar chart that already emits labels= — even with no searchQuery/currency — will now trip hasInteractiveBars (VictoryChartCartesianInteractive.tsx:51), get wrapped in a GestureDetector, and show a label-only hover tooltip (non-clickable, since no searchQuery). Line/area/scatter/horizontal-bar/pie/donut are unaffected (barSeriesConfig is {} for them, so hasInteractiveBars stays false). If some existing bar charts already ship a labels attribute, they'll silently gain hover tooltips — likely intended, just confirm it's desired.

2. Standalone BarChart hover tooltip / pointer-cursor no longer auto-clears on re-layout without mouse movement (low severity, web-only).
The refactor changed isTooltipActive / isCursorOverClickable / isCursorOverTarget from reactive useDerivedValue worklets to plain shared values updated only inside gesture callbacks. The standalone BarChartContent writes barWidth/yZero/chartBottom outside gestures during layout (:130-131, :164, :200) — its hit-test (checkIsOverBar) depends on those. Before, a re-layout/live-data refresh while the cursor sat still over a bar would auto-recompute the derived flags and hide the tooltip / reset the cursor; now the flags stay frozen until the next pointer move. Requires an active hover concurrent with a re-render and a stationary cursor, so it's an edge case, and any micro mouse movement re-syncs it — but it is a real difference for the existing bar chart. The equivalent line-chart path is not affected (its hit-test ignores chartBottom/barWidth/yZero).

Verified clean (no regression):

• Line / area / scatter / horizontal-bar / pie / donut — render through the same plain path as before; the new useVictoryBarInteractions() runs but produces hasInteractiveBars = false with no gesture overlay and no hook-order issue.
• victorySeriesParser rewrite — the data/yKeys output is byte-equivalent (same keys, order, number coercion); only the separate additive pointMetadata field is new.
• parseRawChartData — metadata copies are typeof-guarded; metadata-less points are identical, malformed metadata is dropped.
• ChartTooltip.getTooltipContent — the new if (!amount) return label branch only differs for empty amount; every existing caller (Line/Bar/Pie via useTooltipData) always passes a formatted non-empty amount, so their output is unchanged.
• pointMetadata threading (processVictoryChartTree / context / types) — purely additive; can't alter data/categories/labelItems/legendItems and adds no re-renders (context value was already a fresh literal each render).
• normalizeChartCoordinate — defaults to coordinateScale = 1 for the non-embedded consumers, so e.x / 1 === e.x (no-op); tap/handlePress decision and onEnd cleanup are behaviorally equivalent to before for line/bar.

_{Findings verified from code (PR head b35f125) against victory-native/reanimated internals — I did not run the app. Item 2 is best confirmed with a quick manual check: hover a bar on the analytics dashboard while it re-renders (e.g. resize / data refresh) and watch whether the tooltip clears without moving the mouse.}

Codex and Melvin pointed out that the expand/fullscreen modal still renders the non-interactive chart, so the tooltips and tap-to-search don't work there. Is that intentional for this PR or out of scope?

Codex and Melvin pointed out that the expand/fullscreen modal still renders the non-interactive chart, so the tooltips and tap-to-search don't work there. Is that intentional for this PR or out of scope?

I suggest expand modal support to be out of scope.

The last commit has bug. Modal doesn't dismiss.

Minor: tooltip triangle is separated (need 🦅's 👁️)

I suggest expand modal support to be out of scope.

Yeah, this is getting drawn out with increasing scope creep and fixing that is long. Going to undo last commit for now

cc @mollfpr

Minor: tooltip triangle is separated

Agree, that's a bug. Are you zoomed in or zoomed out by chance? Sometimes that adds the small gap there.

Minor: tooltip triangle is separated

Agree, that's a bug. Are you zoomed in or zoomed out by chance? Sometimes that adds the small gap there.

No zoom. Normal view

Got it! Thanks @inimaga @situchan!

🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96065.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-23680e91b0d-2c5d336-9216baa9999aad3fe5c67483f4aaafb8fc5be802/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-23680e9-2c5d336-b15e513ed89588e1c674e76cebb67272ae6ce00b/index.html

Web 🕸️
https://96065.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.49-0 🚀

Help site review — changes required ✅

This PR adds interactive metadata to the embedded Victory bar charts Concierge renders in chat: on web you can now hover a bar for a tooltip and click a bar to open the matching expenses in Search. That's a new user-facing capability, and the help site didn't document it.

Where it belongs: How Concierge Analyzes Spend covers asking Concierge about your expense data, but never mentioned that Concierge can return an interactive chart — so I added a short section there rather than creating a new article.

Draft help site PR: #97738 — adds a task-based ## How to explore a Concierge spend chart section (interactive chart in chat; hover a bar for a tooltip; select a bar to open its expenses on the Search page) plus retrieval keywords.

@inimaga, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review.

🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.49-3 🚀

Bundle Size Analysis (Sentry):

• Android